fix(cli): make the scan command npx compatible #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argl
changed the title
LeoMcA
approved these changes
Sep 16, 2024
Member
LeoMcA
left a comment
LeoMcA
left a comment
There was a problem hiding this comment.
Nice! Tested locally, works for me, one tiny nit:
bin/scan.js
Outdated
| .name("observatory") | ||
| .description("CLI for the MDN HTTP Observatory") | ||
| .version("1.0.0"); | ||
| const name = "mdn-http-observatory-scan"; |
Member
There was a problem hiding this comment.
Perhaps const NAME = as it's a constant?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move the CLI shell script to a .js implementation, make it compatible with
npxand move it tobin.Motivation
The CLI command should be installable globally.